Adding first pass at ES6 Class support #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
There may also may be a good discussion surrounding what highlighting groups this should be matched with. |
Collaborator
|
Nice work! This is a huge improvement. :) |
* Added support for . within class definition and mapped to jsClassNoise * Linked jsClassNoise to Noise * Tweaked code/whitespace alignment of the jsClass* section
Collaborator
Author
|
I've used this a bunch more, and it's appeared to work well. Any objections to merging this into Dev? |
Collaborator
|
No objections. :) |
amadeus
added a commit
that referenced
this pull request
Mar 9, 2016
Adding first pass at ES6 Class support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been messing around with ES6 lately, so I decided to take the plunge and add proper Class support.
There is a good chance this may have bugs, or things that I have overlooked, however it appears to be working quite well so far.
This is before - as you can see (or not, if you aren't familiar with my color scheme), it's creating the method declarations within the class definition as actual function executions.
This is after - it properly interprets the function definitions and re-uses existing match groups. It also has the benefit of working in very bizarre contexts, as can be seen here (I probably haven't tested every possible scenario, so please let me know if you find issues)
